Lauren fp ts exercises #151
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaureRC
reviewed
Jul 25, 2023
LaureRC
reviewed
Jul 25, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
| ) | ||
|
|
||
| // I checked the solution for the above exercise because I was unable to figure out | ||
| // that "rte.fromReader" needed to proceed the code accessing the TimeService dependency. |
There was a problem hiding this comment.
Let's discuss this in a call then in case you want some extra explanations about this?
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
LaureRC
reviewed
Jul 26, 2023
| @@ -178,10 +220,25 @@ export const pageViewsB = new Map( | |||
| // | |||
| // In case a page appears in both sources, their view count should be summed. | |||
|
|
|||
| export const allPageViews: ReadonlyMap<string, Analytics> = unimplemented(); | |||
|
|
|||
| ////// I needed to look at the solution for this part. I don't feel like I had the tools to figure this out on my own. | |||
There was a problem hiding this comment.
Let me know if you want to discuss this live!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: I'm keeping this as a draft PR so that I don't mistakenly merge it!