Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve consistency across compute policies #11

Merged
merged 7 commits into from
May 12, 2024

Conversation

imrn99
Copy link
Owner

@imrn99 imrn99 commented May 12, 2024

Summary

  • formalize the behavior of the rectangle compute methods
  • split ComputeMethod::Rectangle into ComputeMethod::RectangleLeft and ComputeMethod::RectangleRight

Content

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (7451f03) to head (4b4bcaa).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk      #11      +/-   ##
==========================================
+ Coverage   92.88%   93.52%   +0.63%     
==========================================
  Files           3        3              
  Lines         225      247      +22     
==========================================
+ Hits          209      231      +22     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 merged commit 14da0d1 into trunk May 12, 2024
13 checks passed
@imrn99 imrn99 deleted the improve-policies-consistency branch May 12, 2024 11:40
@imrn99 imrn99 mentioned this pull request May 12, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enh: formalize the interactions between descriptors and computation method
2 participants