Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give visitors proper accesses (and other relevant tweaks) #1499

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

EpicToastTM
Copy link

@EpicToastTM EpicToastTM commented Jan 27, 2025

image
image
image

Visitors now spawn with the PDA corresponding to their roles!

Some ghost roles come with playtime requirements (mostly identical to the normal job requirements, but interns don't have a max hour count, and normal department roles like Scientist and Medical Doctor only need general playtime instead of department playtime).

Also, a bunch of Imp-exclusive cosmetics were added to the visitor ghost role pool, and a jaws of life was added to the disaster escape pod to compensate for the removal of externals access from most visitors.

Changelog
🆑EpicToast

  • add: Add visitor ghost roles for couriers, brigmedics and roboticists.
  • tweak: Visitor ghost roles now spawn with their respective job access.
  • tweak: Some visitor ghost roles (command, security, and others) now come with playtime requirements.
  • tweak: Visitor ghost roles can now spawn with new cosmetics, such as the BROS blazer or the circus clown outfit.

@mqole mqole mentioned this pull request Jan 27, 2025
Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really not sure how i feel about the jaws on the disaster pod, especially given that iirc skeletons can also spawn on those things.

all ids have access to the evac airlocks, thats a pretty viable way of getting on station. could you map an eva suit instead?

@EpicToastTM
Copy link
Author

oh huh, i guess i only tested arrivals
escape pod should already start with two emergency EVAs so i'll just remove the jaws later today

@EpicToastTM
Copy link
Author

just tested, IDs without external access still can't get into evac airlocks from the outside

@EpicToastTM
Copy link
Author

i gueeess i can put another thruster on the escape pod? the alternative is that escape pod ghost roles need to call someone from the station in order to board, but nobody respects ghost roles so i doubt it'd be effective. will try to fit a thruster on it

@EpicToastTM
Copy link
Author

this shit is so ass </3

image

@kipdotnet
Copy link

Surely it would be easier to just give them externals access?

@EpicToastTM
Copy link
Author

i would need to make a visitor version of every PDA with externals access added to it, but i guess there's not that many roles that would need it

@EpicToastTM
Copy link
Author

alright, showered and thought about it -- i'm just going to leave the escape pod shuttle as-is, since my shuttle changes were mostly for qol. those ghost roles can still get on via the arrivals shuttle, the cargo shuttle, or asking crew to open the door from the inside, and that's how it used to work before they added visitor PDAs so i'm not super worried about it. still adding an extra emergency EVA suit though

@iaada
Copy link

iaada commented Jan 28, 2025

I think it's fine that the escape pod has a little more trouble getting on station. Some roles having more friction than others isn't a bad thing.

Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yayyyy

@mqole mqole merged commit 6f51218 into impstation:master Jan 30, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants