Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google & Auth0 authentication #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eraviart
Copy link
Contributor

@eraviart eraviart commented Nov 5, 2016

I added support for Auth0 authentication because this is an easy way to add login/password authentication to HackDash.

To implement it, I had to add two optional fields to providers: name and icon.

You can see it running on https://hackathon.ogpsummit.org (try "Email" authentication).

Caution: provider_id returned by Auth0 are strings instead of numbers. So I changed the type of the provider_id attribute of User but I didn't write the script to convert existing provider_id to strings.

Also improve authentication configuration & convert provider_id to string for Auth0 compatibility.
@impronunciable
Copy link
Owner

@eraviart this is really cool! my only concern is, who is paying for the auth0 auth?

@eraviart
Copy link
Contributor Author

eraviart commented Nov 6, 2016

My understanding of Aut0 site, is that the service is free until we reach 7000 active users per month.

Since we use Auth0 service only for email authentication, I believe I won't reach this limit, even for our "huge" hackathon :-)

@impronunciable
Copy link
Owner

@eraviart Awesome. Thank you very much. I'll take a look and merge if everything is okay.

Thank you very much for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants