-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: persist Linked Verifiable Presentations for did:web
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
force-pushed
the
fix/persist-linked-vps
branch
from
December 2, 2024 15:37
20b85e3
to
77305a2
Compare
daniel-mader
reviewed
Dec 5, 2024
nanderstabel
changed the title
fix: persist Linked Verifiable Presentations
fix: persist Linked Verifiable Presentations for Dec 5, 2024
did:web
daniel-mader
approved these changes
Dec 5, 2024
🎉 This PR is included in version 1.0.0-beta.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue
Previously, whenever UniCore was restarted, it generated a completely new DID Web Document from scratch. This behavior meant that any previously persisted changes to the document were overwritten, resulting in the loss of
LinkedVerifiablePresentation
services upon reboot.Solution
This PR addresses the problem by checking whether a DID Web Document already exists before creating a new one. If an existing document is found, UniCore uses it, ensuring that all previously persisted changes—including
LinkedVerifiablePresentation
services—are retained across restarts.Additional Changes
presentation_ids
field to theService
aggregate. This enhancement makes it easier for implementers to keep track of which presentations are currently being linked.Links to any relevant issues
n/a
How the change has been tested
postgres
event store type./.well-known/did.json
endpoint to validate that it contains a service of typeLinkedVerifiablePresentation
docker compose stop
docker compose start
/.well-known/did.json
endpoint again to validate that it still contains a service of typeLinkedVerifiablePresentation
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.