-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce holder capabilities #113
Conversation
17d38cf
to
f307da3
Compare
fd91c8a
to
fa0e631
Compare
agent_holder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a well-functioning first iteration of the "holder role" 👍 I could not fully assess all technical refactorings, paired with new features - but I like the comments and tests to assert functionality and prevent bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! All three major roles of SSI are now implemented in UniCore! 🥳
🎉 This PR is included in version 1.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 1.0.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description of change
This PR adds Holder functionality to UniCore.
target_url
as well as well as listen for incoming Credential Offers in order to (after confirmation) Accept or Reject the offer.agent_api_rest
agent_shared
rstest
Links to any relevant issues
fixes #111
How the change has been tested
Tested through new and existing (adjusted) unit tests as well as updated Postman Collection.
How to test this flow manually using the Postman Collection:
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.