-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add token_wallet
module to allow funding IOTA DIDs
#8
Draft
daniel-mader
wants to merge
34
commits into
beta
Choose a base branch
from
feat/token-wallet
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
daniel-mader
force-pushed
the
feat/token-wallet
branch
from
April 19, 2024 20:45
4ba528c
to
d985200
Compare
daniel-mader
force-pushed
the
feat/token-wallet
branch
from
April 22, 2024 10:30
a9598a0
to
4f10dab
Compare
daniel-mader
force-pushed
the
refactor/error-handling
branch
from
April 22, 2024 10:32
c989926
to
8d66b22
Compare
daniel-mader
force-pushed
the
feat/token-wallet
branch
from
April 22, 2024 20:08
c3732bc
to
ad082a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
With the new module
token_wallet
a funding address is introduced that can receive IOTA tokens and put down the storage deposit when a non-published IOTA document is produced and published. On destruction of the DID document, the deposit is returned to the funding address and can be sent to a new receiving address (such as a crypto wallet).Additionally, most of the IOTA-related code was moved to a new
did_iota
module.Links to any relevant issues
Depends on
thiserror
to handle errors, produce documents fordid:jwk
anddid:key
according to specifications #4did:iota
from a published DID document #11How the change has been tested
n/a
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.