Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add simple cache for DID documents (optional, configurable, in-memory) #27

Merged
merged 17 commits into from
Aug 28, 2024
Merged

feat: add simple cache for DID documents (optional, configurable, in-memory) #27

merged 17 commits into from
Aug 28, 2024

Conversation

daniel-mader
Copy link
Contributor

Description of change

  • A light-weight optional cache for DID document resolution results is introduced.
  • Creation of a SecretManager was migrated to a builder pattern. The functions generate() and load() are removed and handled implicitly.

Links to any relevant issues

How the change has been tested

Used this version in UniCore and tested the enhanced user experience with UniMe.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader added Addition A new feature that requires a minor release. Enhancement New feature or improvement to an existing feature labels Aug 6, 2024
@daniel-mader daniel-mader self-assigned this Aug 6, 2024
@daniel-mader daniel-mader force-pushed the feat/did-document-caching branch from 8aca6fc to 833019b Compare August 8, 2024 21:44
@daniel-mader daniel-mader changed the title feat: add simple cache for DID documents (optional, configurable) feat: add simple cache for DID documents (optional, configurable, in-memory) Aug 8, 2024
@daniel-mader daniel-mader marked this pull request as ready for review August 8, 2024 21:48
nanderstabel
nanderstabel requested changes Aug 13, 2024
View reviewed changes
producer/src/did_document.rs Outdated Show resolved Hide resolved
producer/src/secret_manager.rs Outdated Show resolved Hide resolved
producer/src/secret_manager.rs Outdated Show resolved Hide resolved
producer/src/secret_manager.rs Outdated Show resolved Hide resolved
producer/src/secret_manager.rs Outdated Show resolved Hide resolved
producer/src/cache.rs Outdated Show resolved Hide resolved
@daniel-mader daniel-mader changed the base branch from dev to main August 14, 2024 12:37
@daniel-mader daniel-mader changed the base branch from main to beta August 14, 2024 20:36
@daniel-mader daniel-mader merged commit 6880b7f into beta Aug 28, 2024
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@daniel-mader daniel-mader deleted the feat/did-document-caching branch August 28, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanderstabel nanderstabel nanderstabel approved these changes

Assignees

@daniel-mader daniel-mader

Labels
Addition A new feature that requires a minor release. Enhancement New feature or improvement to an existing feature released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache DID documents
2 participants
@daniel-mader @nanderstabel