-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fork tests for flow rate controls #85
Conversation
📃CI ReportCompiling 143 files with 0.8.19
For a full HTML report run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, just some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR introduces fork tests to check the flow rate control capabilities of the bridge, a crucial security feature. Despite the existence of numerous unit and integration tests for this function, it's necessary to test it against a deployed version of the bridge. Here, parameters, configurations, and token contract idiosyncrasies could potentially affect its functionality. However, running live E2E tests on the flow rate control feature on mainnet isn't feasible. Hence, these tests serve as an alternative way to confirm that this capability works as expected under a range of conditions, in all bridge deployment environments.
This PR addresses SMR-2336-SMR-2238