Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document risk of lost funds if receiver lacks fallback #73

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ermyas
Copy link
Collaborator

@ermyas ermyas commented Dec 11, 2023

This PR adds natspec comments highlighting the risk raised in issue #59, and also tracked through SMR-2116
In addition, checks have been implemented on the front-end layer to mitigate this risk, as detailed in SMR-2112.

@platform-sa
Copy link

📃CI Report

Compiling 141 files with 0.8.19
Solc 0.8.19 finished in 16.83s
Compiler run �[32msuccessful!�[0m
Analysing contracts...
Running tests...

File % Lines % Statements % Branches % Funcs
src/child/ChildAxelarBridgeAdaptor.sol 100.00% (48/48) 100.00% (65/65) 100.00% (22/22) 100.00% (7/7)
src/child/ChildERC20.sol 100.00% (14/14) 100.00% (15/15) 50.00% (1/2) 100.00% (7/7)
src/child/ChildERC20Bridge.sol 96.97% (128/132) 97.75% (174/178) 94.29% (66/70) 100.00% (21/21)
src/child/WIMX.sol 0.00% (0/19) 0.00% (0/22) 0.00% (0/8) 0.00% (0/6)
src/common/AdaptorRoles.sol 100.00% (6/6) 100.00% (6/6) 100.00% (0/0) 100.00% (6/6)
src/common/BridgeRoles.sol 100.00% (8/8) 100.00% (8/8) 100.00% (0/0) 100.00% (8/8)
src/lib/EIP712MetaTransaction.sol 8.00% (2/25) 9.68% (3/31) 8.33% (1/12) 14.29% (1/7)
src/lib/EIP712Upgradeable.sol 73.33% (11/15) 60.87% (14/23) 0.00% (0/2) 50.00% (2/4)
src/lib/WETH.sol 100.00% (19/19) 100.00% (22/22) 100.00% (8/8) 100.00% (6/6)
src/root/RootAxelarBridgeAdaptor.sol 100.00% (48/48) 100.00% (65/65) 100.00% (22/22) 100.00% (7/7)
src/root/RootERC20Bridge.sol 93.65% (118/126) 95.58% (173/181) 87.50% (49/56) 90.91% (20/22)
src/root/flowrate/FlowRateDetection.sol 100.00% (30/30) 100.00% (33/33) 100.00% (14/14) 100.00% (4/4)
src/root/flowrate/FlowRateWithdrawalQueue.sol 100.00% (46/46) 100.00% (60/60) 78.57% (11/14) 100.00% (7/7)
src/root/flowrate/RootERC20BridgeFlowRate.sol 100.00% (42/42) 97.96% (48/49) 100.00% (10/10) 100.00% (9/9)

For a full HTML report run: forge coverage --report lcov && genhtml --ignore-errors category --branch-coverage --output-dir coverage lcov.info

Copy link

Document risk of lost funds if receiver lacks fallback

Generated at commit: 95f896becdb1e9f442c5eccffc7cf76ffbc3cc88

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
0
0
10
31
42
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@ermyas ermyas merged commit fb42ddf into main Dec 12, 2023
5 checks passed
@ermyas ermyas deleted the SMR2116/document/risk-lost-funds branch April 12, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants