Nojira update scripts #58
Conversation
📃CI ReportCompiling 143 files with 0.8.19
For a full HTML report run: |
Add create2 contract deployer with access control
Nojira update scripts
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
.github/workflows/coverage.yml
Outdated
| @@ -25,7 +25,7 @@ jobs: | |||
| - name: Install Foundry | |||
| uses: foundry-rs/foundry-toolchain@v1 | |||
| with: | |||
| version: nightly-34f684ddfacc5b2ed371353ba6f730c485616ffe | |||
| version: nightly-caef1360e29dfefb1723fa501f425e6f7824bf7f | |||
There was a problem hiding this comment.
Specific nightly builds for Foundry are apparently pruned every few days (see here for more), so it is possible that this build could eventually fail. While they periodically have pinned nightly releases, it is not clear which these are.
I'd suggest we remove the specific version and use "nightly" instead.
| * Attempting to deploy a contract with the same bytecode, salt, and sender(owner) will revert. | ||
| * The address where the contract will be deployed can be found using {deployedAddress}. | ||
| */ | ||
| contract OwnableCreate2Deployer is Ownable, Create2, Deployer { |
There was a problem hiding this comment.
I don't think we need this contract here any more, given we've moved it to a separate repo?
There was a problem hiding this comment.
That is correct. I'll remove this contract
No description provided.