Extract GMP specific logic out of bridge contracts #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📃CI ReportCompiling 146 files with 0.8.19
For a full HTML report run: |
tsnewnami
reviewed
Nov 22, 2023
| @@ -43,7 +43,7 @@ contract InitializeChildContracts is Script { | |||
| childERC20Bridge: ChildERC20Bridge(payable(vm.envAddress("CHILD_ERC20_BRIDGE"))), | |||
| childAxelarBridgeAdaptor: ChildAxelarBridgeAdaptor(vm.envAddress("CHILD_BRIDGE_ADAPTOR")), | |||
| childTokenTemplate: vm.envAddress("CHILDCHAIN_CHILD_TOKEN_TEMPLATE"), | |||
| rootERC20BridgeAdaptor: vm.envAddress("ROOT_BRIDGE_ADAPTOR"), | |||
| rootBridgeAdaptor: vm.envAddress("ROOT_BRIDGE_ADAPTOR"), | |||
There was a problem hiding this comment.
QQ, with the introduction of @wcgcyx's scripts, what purpose do these forge scripts hold?
There was a problem hiding this comment.
Good question. I believe @wcgcyx PR will remove these scripts once it is merged.
| */ | ||
| interface IChildERC20BridgeAdaptor { | ||
| interface IChildBridgeAdaptor { |
There was a problem hiding this comment.
nice, I see this being generalizable across other asset types
| rootBridgeAdaptor = IRootERC20BridgeAdaptor(newRootBridgeAdaptor); | ||
| childBridgeAdaptor = newChildBridgeAdaptor; | ||
| childChain = newChildChain; | ||
| rootBridgeAdaptor = IRootBridgeAdaptor(newRootBridgeAdaptor); |
There was a problem hiding this comment.
not for this PR perhaps, but is it worth integrating ERC165 into the adaptor? That is we can check interface IDs on adaptor updating?
There was a problem hiding this comment.
Yeah, I agree! I'll capture this on Jira for a future PR.
tsnewnami
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, the RootERC20Bridge and ChildERC20Bridge implementations are implicitly linked to Axelar-specific details, such as chain names for chain IDs and string contract addresses. This PR moves these details from the bridge contract to the respective bridge adaptors. A crucial part of this refactor is that the validation of a message's source (i.e., source chain and source address) is now carried out at the bridge adaptor, not at the bridge.
This PR addresses SMR-2023, SMR-2024, SMR-2026