[SMR-1908] Setters #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📃CI ReportCompiling 148 files with 0.8.19
For a full HTML report run: |
ermyas
reviewed
Nov 20, 2023
| childBridge.updateRootBridgeAdaptor(newAdaptor); | ||
| } | ||
|
|
||
| function test_RevertIf_updateRootBridgeAdaptorCalledByNotTargetManager() public { |
There was a problem hiding this comment.
should this be adaptor manager and not target manager
Suggested change
| function test_RevertIf_updateRootBridgeAdaptorCalledByNotTargetManager() public { | |
| function test_RevertIf_updateRootBridgeAdaptorCalledByNotAdaptorManager() public { |
ermyas
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing setters e.g.
updateRootBridgeAdaptorandupdateChildBridgeAdaptor, addsAdaptorRolesand setters for the adaptors and fix some missing cases in tests.