Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smr 1815 wimx withdraw #27

Merged
merged 16 commits into from
Nov 14, 2023
Merged

Smr 1815 wimx withdraw #27

merged 16 commits into from
Nov 14, 2023

Conversation

wcgcyx
Copy link
Contributor

@wcgcyx wcgcyx commented Nov 7, 2023 •
edited
Loading

This PR enables the withdrawal flow of Wrapped IMX from L2 to L1.

@rzmahmood
Copy link
Contributor

PR Description please

ermyas
ermyas reviewed Nov 12, 2023
View reviewed changes
src/child/ChildERC20Bridge.sol Show resolved Hide resolved
src/child/ChildERC20Bridge.sol Outdated Show resolved Hide resolved
src/child/ChildERC20Bridge.sol Show resolved Hide resolved
src/child/ChildERC20Bridge.sol Show resolved Hide resolved
tsnewnami
tsnewnami reviewed Nov 13, 2023
View reviewed changes
src/child/ChildERC20Bridge.sol Show resolved Hide resolved
src/child/ChildERC20Bridge.sol Show resolved Hide resolved
src/child/ChildERC20Bridge.sol Show resolved Hide resolved
src/interfaces/child/IChildERC20Bridge.sol Outdated Show resolved Hide resolved
src/interfaces/child/IChildERC20Bridge.sol Show resolved Hide resolved
@tsnewnami tsnewnami force-pushed the SMR-1815-WIMX-withdraw branch from baf38b6 to adf9f9c Compare November 14, 2023 04:08
@platform-sa
Copy link

platform-sa commented Nov 14, 2023 •
edited
Loading

📃CI Report

Compiling 130 files with 0.8.19
Solc 0.8.19 finished in 14.66s
Compiler run �[32msuccessful!�[0m
Analysing contracts...
Running tests...

File % Lines % Statements % Branches % Funcs
script/DeployChildContracts.s.sol 0.00% (0/22) 0.00% (0/32) 100.00% (0/0) 0.00% (0/1)
script/DeployRootContracts.s.sol 0.00% (0/27) 0.00% (0/37) 0.00% (0/2) 0.00% (0/1)
script/InitializeChildContracts.s.sol 0.00% (0/10) 0.00% (0/15) 100.00% (0/0) 0.00% (0/1)
script/InitializeRootContracts.s.sol 0.00% (0/10) 0.00% (0/15) 100.00% (0/0) 0.00% (0/1)
script/Utils.sol 0.00% (0/12) 0.00% (0/16) 0.00% (0/2) 0.00% (0/2)
src/child/ChildAxelarBridgeAdaptor.sol 100.00% (16/16) 100.00% (19/19) 100.00% (6/6) 100.00% (3/3)
src/child/ChildERC20.sol 100.00% (14/14) 100.00% (15/15) 50.00% (1/2) 100.00% (7/7)
src/child/ChildERC20Bridge.sol 97.58% (121/124) 98.26% (169/172) 94.44% (68/72) 100.00% (12/12)
src/child/WIMX.sol 0.00% (0/19) 0.00% (0/22) 0.00% (0/8) 0.00% (0/6)
src/lib/EIP712MetaTransaction.sol 8.00% (2/25) 9.68% (3/31) 8.33% (1/12) 14.29% (1/7)
src/lib/EIP712Upgradeable.sol 73.33% (11/15) 60.87% (14/23) 0.00% (0/2) 50.00% (2/4)
src/root/RootAxelarBridgeAdaptor.sol 100.00% (18/18) 100.00% (24/24) 100.00% (8/8) 100.00% (3/3)
src/root/RootERC20Bridge.sol 95.49% (127/133) 96.98% (193/199) 90.00% (63/70) 100.00% (17/17)

For a full HTML report run: forge coverage --report lcov && genhtml --ignore-errors category --branch-coverage --output-dir coverage lcov.info

@tsnewnami tsnewnami merged commit 5a46b04 into main Nov 14, 2023
4 checks passed
@ermyas ermyas deleted the SMR-1815-WIMX-withdraw branch April 12, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsnewnami tsnewnami tsnewnami left review comments

@rzmahmood rzmahmood rzmahmood left review comments

@ermyas ermyas ermyas approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wcgcyx @rzmahmood @platform-sa @ermyas @tsnewnami