Smr 1814 Part 2 imx withdraw on L1 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ermyas
reviewed
Nov 6, 2023
| bytes32 commandId = bytes32("testCommandId"); | ||
| string memory sourceAddress = rootBridge.childBridgeAdaptor(); | ||
|
|
||
| uint256 thisPreBal = imxToken.balanceOf(receiver); |
There was a problem hiding this comment.
nit: thisPreBal is a bit misleading on this test, since it is the receiver's balance not this contract's balance like the previous test
|
|
||
| axelarAdaptor.execute(commandId, CHILD_CHAIN_NAME, sourceAddress, data); | ||
|
|
||
| uint256 thisPostBal = imxToken.balanceOf(receiver); |
There was a problem hiding this comment.
nit: thisPostBal is a bit misleading on this test, since it is the receiver's balance not this contract's balance like the previous test
| // Give bridge some IMX tokens | ||
| imxToken.transfer(address(rootBridge), 100 ether); | ||
|
|
||
| uint256 thisPreBal = imxToken.balanceOf(address(receiver)); |
There was a problem hiding this comment.
nit: same comment as above on thisPreBal
Benjimmutable
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #18 and #21