Smr 1813 withdraw erc20s #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…idge-contracts into smr-1813-withdraw-erc20s
…idge-contracts into smr-1813-withdraw-erc20s
wcgcyx
approved these changes
Nov 3, 2023
| // 0000000000000000000000007fa9385be102ac3eac297483dd6233d62b3e1496 | ||
| // 000000000000000000000000000000000000000000000000000000174876e7ff | ||
|
|
||
| // bytes memory payload = abi.encode(MAP_TOKEN_SIG, address(token), token.name(), token.symbol(), token.decimals()); |
| } | ||
|
|
||
| // A mapped token should never have root token unset | ||
| if (rootToken == address(0)) { |
There was a problem hiding this comment.
This should never happen, right?
There was a problem hiding this comment.
That's correct, it's copied from here as an extra safety check: https://github.com/immutable/poly-core-contracts/blob/main/contracts/child/ChildERC20Predicate.sol#L171-L172
wcgcyx
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L2 side of Withdraw ERC20 tokens