Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SMR-1772] Proxies on deployment #15

Merged
merged 10 commits into from
Nov 1, 2023
Merged

Conversation

Benjimmutable
Copy link
Contributor

@Benjimmutable Benjimmutable commented Oct 31, 2023

https://immutable.atlassian.net/browse/SMR-1772
A contract to start using upgradeable proxies in all the relevant bridge contracts.

The ./deploy.sh script now needs to do a number of steps:

  1. Since there are two TransparentUpgradeableProxy.sol contracts per script, we can not uniquely identify the bridge and the bridge adaptor this way.
  2. Therefore, get the addresses of all the proxies, then query each one's implementation address in order to see which one is the bridge and which one is the bridge adaptor.

@Benjimmutable Benjimmutable self-assigned this Oct 31, 2023
@Benjimmutable Benjimmutable marked this pull request as ready for review October 31, 2023 23:11
@Benjimmutable Benjimmutable changed the title Proxies on deployment [SMR-1772] Proxies on deployment Oct 31, 2023
README.md Outdated Show resolved Hide resolved
src/child/ChildAxelarBridgeAdaptor.sol Outdated Show resolved Hide resolved
src/root/RootAxelarBridgeAdaptor.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@wcgcyx wcgcyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!


export ROOT_ERC20_BRIDGE=$root_erc20_bridge
export ROOT_BRIDGE_ADAPTOR=$root_bridge_adaptor
# In the TransparentUpgradeableProxy contract, you have to query the storage slot directly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Benjimmutable Benjimmutable merged commit 0b76195 into main Nov 1, 2023
3 checks passed
@Benjimmutable Benjimmutable deleted the proxies-on-deployment branch November 1, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants