Skip to content

Commit

Permalink
checkout file
Browse files Browse the repository at this point in the history
  • Loading branch information
tsnewnami committed Nov 21, 2023
1 parent 01c75b6 commit 0810795
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions script/DeployChildContracts.s.sol
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import {ChildAxelarBridgeAdaptor} from "../src/child/ChildAxelarBridgeAdaptor.so
import {ChildERC20} from "../src/child/ChildERC20.sol";
import {WIMX} from "../src/child/WIMX.sol";

// TODO update private key usage to be more secure: https://book.getfoundry.sh/reference/forge/forge-script#wallet-options---raw

contract DeployChildContracts is Script {
function run() public {
uint256 deployerPrivateKey = vm.envUint("CHILD_PRIVATE_KEY");
Expand Down
2 changes: 1 addition & 1 deletion src/root/RootERC20Bridge.sol
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ contract RootERC20Bridge is BridgeRoles, IRootERC20Bridge, IRootERC20BridgeEvent
// ETH also cannot be transferred since it was received in the payable function call
// WETH is also not transferred here since it was earlier unwrapped to ETH

// We can call _mapToken here, but ordering in the GMP is not guaranteed.
// TODO We can call _mapToken here, but ordering in the GMP is not guaranteed.
// Therefore, we need to decide how to handle this and it may be a UI decision to wait until map token message is executed on child chain.
// Discuss this, and add this decision to the design doc.

Expand Down

0 comments on commit 0810795

Please sign in to comment.