Added a script so we can grant the executor role to MultiCallDeploy #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnewnami
reviewed
Feb 19, 2024
| const contractFactory: ContractFactory = await newContractFactory(wallets.getWallet(), contractName); | ||
|
|
||
| console.log(`[${network}] Confirm contract address ${multiCallDeployContractAddress} ...`); | ||
| const multiCallDeploy: Contract = await contractFactory.attach(multiCallDeployContractAddress); |
There was a problem hiding this comment.
Alternative which may be simpler:
await hre.ethers.getContractAt("MultiCallDeploy", contractAddress);
There was a problem hiding this comment.
@Edwardjes do you mind if I keep the 2 step? The function newContractFactory is one I wrote that is also used by the deployment scripts, and for consistency i'd like they be all the same without a more pervasive change. Thoughts?
tsnewnami
reviewed
Feb 19, 2024
tsnewnami
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a new script to execute on
devnetto give the new Submitters addresses theexecutorrole on theMultiCallDeploycontract.