Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link readme to official docs #39

Merged
merged 2 commits into from
Nov 15, 2023
Merged

docs: link readme to official docs #39

merged 2 commits into from
Nov 15, 2023

Conversation

nattb8
Copy link
Collaborator

@nattb8 nattb8 commented Nov 8, 2023

Link the README to the official docs. This way, updating both places won't be necessary. This applies only to identical documentation.

@suluvai
Copy link
Contributor

suluvai commented Nov 8, 2023

@nattb8 all for avoiding the work duplication, how would the work flow look like after this change to make new feature releases?

@nattb8
Copy link
Collaborator Author

nattb8 commented Nov 8, 2023

@nattb8 all for avoiding the work duplication, how would the work flow look like after this change to make new feature releases?

You just need to update the public docs (imx-docs) since it's linked. Currently, you already have to copy the exact information into the README and the public docs.

Note that this doesn't apply to sections like Plugin Maintainers' Guide, as we don't add that to the public docs.

Does that answer your question? Or did I misunderstand your question? What is your concern?

@suluvai
Copy link
Contributor

suluvai commented Nov 8, 2023

@nattb8 you did answer the question.

The only concern I might raise is, the documentation process is decoupled with the actual changes now. May lead to getting missed out or left behind with actual changes.

@nattb8
Copy link
Collaborator Author

nattb8 commented Nov 8, 2023 via email

@suluvai
Copy link
Contributor

suluvai commented Nov 8, 2023

I don't see how having the documentation in the README would prevent people from forgetting to update it. There is no automation that checks whether the README and public docs are both updated when you release new features. Currently, we just rely on the DoD of the ticket to update it. Could you please explain how having the documentation in the README would prevent people from missing it?

When it is part of the same PR along with the changes it gets picked up by reviewers.

I am not against this, just voiced my view. If everyone is happy with this approach, happy to go along.

Copy link
Contributor

@carleeto carleeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Getting Started section, there's a link to the User Guide section (which has been renamed to Documentation), which needs to be updated.
image

image

https://github.com/immutable/unreal-immutable-sdk/blob/docs/clean-up-readme/README.md?plain=1#L32

@nattb8 nattb8 requested a review from carleeto November 9, 2023 01:38
@nattb8 nattb8 merged commit e7c75d7 into main Nov 15, 2023
3 checks passed
@nattb8 nattb8 deleted the docs/clean-up-readme branch November 15, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants