This repository has been archived by the owner on May 16, 2024. It is now read-only.
CORE-2033 Add RegistrationV4 contract #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…33-add-v2-registration-contract
…952-add-v2-complete-withdrawal-flow
…952-add-v2-complete-withdrawal-flow
…33-add-v2-registration-contract
…33-add-v2-registration-contract
…33-add-v2-registration-contract
brayansdt
reviewed
Feb 26, 2024
| OnEvent, | ||
| } from "../common"; | ||
|
|
||
| export interface RegistrationV2Interface extends utils.Interface { |
There was a problem hiding this comment.
Can we please rename it to RegistrationV4 as the contract name deployed on-chain is now called RegistrationV4?
Base automatically changed from
CORE-1952-add-v2-complete-withdrawal-flow
to
main
February 27, 2024 01:49
carleeto
approved these changes
Feb 27, 2024
brayansdt
changed the title
brayansdt
reviewed
Feb 27, 2024
contracts/v4/Core.sol
Outdated
| // SPDX-License-Identifier: UNLICENSED | ||
| pragma solidity ^0.8.19; | ||
|
|
||
| interface Core { |
There was a problem hiding this comment.
this is outdated, can you please have a look at https://github.com/immutable/contracts/tree/main/contracts/bridge/x/v4
brayansdt
reviewed
Feb 27, 2024
contracts/v4/Registration.sol
Outdated
|
|
||
| import {Core} from "./Core.sol"; | ||
|
|
||
| contract Registration { |
There was a problem hiding this comment.
this is outdated, can you please have a look at https://github.com/immutable/contracts/tree/main/contracts/bridge/x/v4
brayansdt
reviewed
Feb 27, 2024
| event ImplementationActivationRescheduled(address indexed implementation, uint256 updatedActivationTime); | ||
|
|
||
| function updateImplementationActivationTime(address implementation, bytes memory data, bool finalize) external; | ||
| } |
brayansdt
reviewed
Feb 27, 2024
| function isRegistered(uint256 starkKey) public view returns (bool) { | ||
| return imx.getEthKey(starkKey) != address(0); | ||
| } | ||
| } |
brayansdt
reviewed
Feb 27, 2024
| overrides?: Overrides & { from?: string } | ||
| ): Promise<PopulatedTransaction>; | ||
| }; | ||
| } |
brayansdt
approved these changes
Feb 27, 2024
| ): RegistrationV4 { | ||
| return new Contract(address, _abi, signerOrProvider) as RegistrationV4; | ||
| } | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why the changes
Things worth calling out
Before merging
N/A):