This repository has been archived by the owner on May 16, 2024. It is now read-only.
CORE-1952 add v2 complete withdrawal #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaihirota
changed the title
kaihirota
changed the base branch from
CORE-1942-create-withdrawal-v2
to
CORE-1952-add-v4-starkex-contract-bindings
kaihirota
force-pushed
the
CORE-1952-add-v4-starkex-contract-bindings
branch
from
ecca3ee to
6f7cb14
Compare
kaihirota
force-pushed
the
CORE-1952-add-v2-complete-withdrawal-flow
branch
from
8d90fd7 to
38daa61
Compare
…952-add-v2-complete-withdrawal-flow
brayansdt
reviewed
Feb 26, 2024
Base automatically changed from
CORE-1952-add-v4-starkex-contract-bindings
to
main
February 26, 2024 05:38
brayansdt
approved these changes
Feb 26, 2024
kaihirota
commented
Feb 27, 2024
| @@ -592,19 +592,17 @@ export class ImmutableX { | |||
|
|
|||
| /** | |||
| * Completes a Withdrawal | |||
| * @param ethSigner - the L1 signer | |||
| * @param starkPublicKey - the Signer address | |||
| * @param walletConnection - the pair of L1/L2 signers | |||
There was a problem hiding this comment.
Parameter change necessary because completeWithdrawal needs stark signer in order to do registerEthAddress in StarkEx V4
carleeto
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why the changes
Things worth calling out
Before merging
N/A):