This repository has been archived by the owner on May 16, 2024. It is now read-only.
Update open api client to latest open api spec #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Li <[email protected]>
Signed-off-by: Frank Li <[email protected]>
Signed-off-by: Frank Li <[email protected]>
frankisawesome
changed the title
lfportal
reviewed
Feb 5, 2024
lfportal
approved these changes
Feb 5, 2024
CodeSchwert
approved these changes
Feb 6, 2024
Comment on lines
-456
to
-470
| /** | ||
| * Create a Project | ||
| * @param ethSigner - the L1 signer | ||
| * @param request - the request object containing the parameters to be provided in the API request | ||
| * @returns a promise that resolves with the created Project | ||
| * @throws {@link index.IMXError} | ||
| */ | ||
| public async createProject( | ||
| ethSigner: EthSigner, | ||
| request: CreateProjectRequest, | ||
| ) { | ||
| return this.workflows | ||
| .createProject(ethSigner, request) | ||
| .then(res => res.data) | ||
| .catch(err => { |
There was a problem hiding this comment.
@frankisawesome this feels like a potentially very small breaking change? Could we get away with a minor version bump because project creation has moved to Hub? cc: @wdinau
There was a problem hiding this comment.
Note, this would affect Unified SDK too since Core SDK is a dependency and requests are proxied through to Core SDK.
There was a problem hiding this comment.
Discussed offline - these changes are OK'd by the hub team and we've confirmed these are intentional deletions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Why the changes
Things worth calling out
Before merging
N/A):