ERC 20 contracts V2 #222
Closed
ERC 20 contracts V2 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ERC 20 contracts V2
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
ipekt
reviewed
May 21, 2024
| // solhint-disable no-unused-import | ||
| import {HubOwner, AccessControlEnumerable, AccessControl, IAccessControl} from "./HubOwner.sol"; | ||
|
|
||
| abstract contract MintingHubOwner is HubOwner { |
There was a problem hiding this comment.
Which application/feature will use MintingHubOwner role?
|
This PR is going to be abandoned. Though the new ERC 20 contracts provide some improvements over the existing contracts, this improvement is not substantive enough to warrant an upgrade. The branch will be kept alive, and will be able to be used as the basis for further improvements to the ERC20 contract system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a V2 version of the ERC 20 presets. These new presets provide a cleaner, more consistent API.
Original ERC 20 contracts (V1 contracts) are deprecated, but still available.