Update formatting given recent forge fmt changes #707
ermyastest.yml
on: pull_request
Run Forge Tests
1m 17s
Run Hardhat Tests
1m 16s
Run eslint
31s
Run solhint
27s
Run slither
10m 51s
Check README.md is contained in each contracts directory
2s
Publish to NPM (dry run)
1m 15s
Annotations
11 errors and 7 warnings
|
Run solhint:
contracts/access/MintingAccessControl.sol#L6
Replace ⏎····AccessControlEnumerable,⏎····AccessControl,⏎····IAccessControl⏎ with AccessControlEnumerable,·AccessControl,·IAccessControl
|
|
|
|
|
|
|
|
Run solhint:
contracts/allowlist/OperatorAllowlistUpgradeable.sol#L166
Replace bytes4·interfaceId) with ⏎········bytes4·interfaceId
|
|
Run solhint:
contracts/allowlist/OperatorAllowlistUpgradeable.sol#L167
Replace ····public⏎········view⏎········virtual⏎········override(ERC165,·AccessControlEnumerableUpgradeable)⏎········returns·(bool)⏎··· with )·public·view·virtual·override(ERC165,·AccessControlEnumerableUpgradeable)·returns·(bool)
|
|
Run solhint:
contracts/mocks/MockMarketplace.sol#L37
Replace ⏎········public⏎········payable⏎··· with ·public·payable
|
|
Run solhint:
contracts/mocks/MockOnReceive.sol#L17
Replace address,·/*·operator·*/·address,·/*·from·*/·uint256·tokenId,·bytes·calldata·/*·data·*/·) with ⏎········address,⏎········/*·operator·*/·address,⏎········/*·from·*/·uint256·tokenId,⏎········bytes·calldata·/*·data·*/
|
|
Run solhint:
contracts/mocks/MockOnReceive.sol#L18
Replace ····public⏎········returns·(bytes4)⏎··· with )·public·returns·(bytes4)
|
|
Run solhint:
contracts/mocks/MockWallet.sol#L24
Replace address·operator,·address·from,·uint256·tokenId,·bytes·calldata·data) with ⏎········address·operator,⏎········address·from,⏎········uint256·tokenId,⏎········bytes·calldata·data
|
|
Run slither
Process completed with exit code 255.
|
|
Check README.md is contained in each contracts directory
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run solhint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run eslint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Publish to NPM (dry run)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run Hardhat Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run Forge Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run slither
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|