Enable more flexible access controls for contract deployment #706
ermyastest.yml
on: pull_request
Run Forge Tests
1m 21s
Run Hardhat Tests
1m 17s
Run eslint
35s
Run solhint
30s
Run slither
10m 41s
Check README.md is contained in each contracts directory
2s
Publish to NPM (dry run)
1m 15s
Annotations
11 errors and 11 warnings
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L27
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L28
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L29
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L45
Replace IDeployer·deployer,·bytes·memory·bytecode,·bytes32·salt) with ⏎········IDeployer·deployer,⏎········bytes·memory·bytecode,⏎········bytes32·salt
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L46
Replace ········external⏎········payable⏎········whenNotPaused⏎········onlyRole(DEPLOYER_ROLE)⏎········returns·(address)⏎··· with ····)·external·payable·whenNotPaused·onlyRole(DEPLOYER_ROLE)·returns·(address)
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L52
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L66
Replace IDeployer·deployer,·bytes·memory·bytecode,·bytes32·salt,·bytes·calldata·init) with ⏎········IDeployer·deployer,⏎········bytes·memory·bytecode,⏎········bytes32·salt,⏎········bytes·calldata·init
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L67
Replace ········external⏎········payable⏎········whenNotPaused⏎········onlyRole(DEPLOYER_ROLE)⏎········returns·(address)⏎··· with ····)·external·payable·whenNotPaused·onlyRole(DEPLOYER_ROLE)·returns·(address)
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L73
Use Custom Errors instead of require statements
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L85
Use Custom Errors instead of require statements
|
|
Run slither
Process completed with exit code 255.
|
|
Check README.md is contained in each contracts directory
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run solhint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L52
Error message for require is too long
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L73
Error message for require is too long
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L118
Error message for require is too long
|
|
Run solhint:
contracts/deployer/AccessControlledDeployer.sol#L120
Error message for require is too long
|
|
Run eslint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Publish to NPM (dry run)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run Hardhat Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run Forge Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Run slither
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|