Skip to content
test

DRAFT: Enable Slither github action; Resolve slither, solhint and eslint issues #418

Sign in to view logs

DRAFT: Enable Slither github action; Resolve slither, solhint and eslint issues

DRAFT: Enable Slither github action; Resolve slither, solhint and eslint issues #418

Triggered via pull request January 24, 2024 05:21
@drinkcoffeedrinkcoffee
synchronize #168
slither
Status Failure
Total duration 1m 34s
Artifacts –

test.yml

on: pull_request
Run Forge Tests
52s
Run Forge Tests
Run Hardhat Tests
1m 25s
Run Hardhat Tests
Run eslint
30s
Run eslint
Run solhint
26s
Run solhint
Run slither
1m 25s
Run slither
Publish to NPM (dry run)
1m 7s
Publish to NPM (dry run)
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 10 warnings
Run solhint: contracts/access/IERC173.sol#L2
Compiler version ^0.8.0 does not satisfy the 0.8.19 semver requirement
Run solhint: contracts/mocks/MockMarketplace.sol#L29
Use Custom Errors instead of require statements
Run solhint: contracts/mocks/MockWalletFactory.sol#L26
Use Custom Errors instead of require statements
Run solhint
Process completed with exit code 1.
Run eslint: clients/erc20.ts#L32
Insert `,`
Run eslint: clients/erc20.ts#L44
Insert `,`
Run eslint: clients/erc20.ts#L55
Insert `,`
Run eslint: clients/erc20.ts#L66
Insert `,`
Run eslint: clients/erc20.ts#L78
Insert `,`
Run eslint: clients/erc721-mint-by-id.ts#L53
Insert `,`
Run eslint: clients/erc721-mint-by-id.ts#L85
Insert `,`
Run eslint: clients/erc721-mint-by-id.ts#L96
Insert `,`
Run eslint: clients/erc721-mint-by-id.ts#L108
Insert `,`
Run eslint: clients/erc721-mint-by-id.ts#L119
Insert `,`
Run solhint: contracts/access/IERC173.sol#L4
global import of path @openzeppelin/contracts/utils/introspection/ERC165.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
Run solhint: contracts/allowlist/IWalletProxy.sol#L10
Function name must be in mixedCase
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L43
Main key parameter in mapping addressAllowlist is not named
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L43
Value parameter in mapping addressAllowlist is not named
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L46
Main key parameter in mapping addressImplementationAllowlist is not named
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L46
Value parameter in mapping addressImplementationAllowlist is not named
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L49
Main key parameter in mapping bytecodeAllowlist is not named
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L49
Value parameter in mapping bytecodeAllowlist is not named
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L101
Avoid to use inline assembly. It is acceptable only in rare cases
Run solhint: contracts/allowlist/OperatorAllowlistUpgradeable.sol#L120
Avoid to use inline assembly. It is acceptable only in rare cases