Ensure transaction finishes before returning results (#4)

immuta · Dec 16, 2022 · 5d60a6c · 5d60a6c
1 parent b51e933
commit 5d60a6c
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/lib/adapter.js b/lib/adapter.js
@@ -257,6 +257,7 @@ const Adapter = {
   create (connectionName, tableName, record, cb) {
     let cxn = this.connections.get(connectionName)
     let pk = this.getPrimaryKey(cxn, tableName)
+    let newRecord;
 
     return cxn.knex.transaction(txn => {
       return txn.insert(Util.castRecord(record))
@@ -265,11 +266,13 @@ const Adapter = {
           return txn.select().from(tableName).where('rowid', rowid)
         })
         .then(([ created ]) => {
-          let record = Util.castSqlValues(created, cxn.collections[tableName])
-          _.isFunction(cb) && cb(null, record)
-          return record
+          newRecord = Util.castSqlValues(created, cxn.collections[tableName])
+          return newRecord
         })
         .catch(AdapterError.wrap(cb))
+    }).then(() => {
+      _.isFunction(cb) && cb(null, newRecord)
+      return newRecord;
     })
   },