This repository has been archived by the owner on May 22, 2024. It is now read-only.
Throw re.error when invalidregex is provided #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you xfail the tests that will break? |
|
I think the tests that fail have nothing to do with my changes or do they? |
|
I think they do. The master has passing tests, but the tests fail on this branch. https://github.com/i10b/simplematrixbotlib/runs/5240125176?check_suite_focus=true |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (breaking) change will change the behavior of adding and removing to allowlist and blocklist. Provided with en invalid regex to add/remove the library will no longer only print an error and not change the allow and blocklist but fail with
re.error. This enables users of the library to determine if the action was successful. This can also happen inload_tomlas the regex patterns for allowlist and blocklist are compiled.