Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV and replace "minimal-versions" check with "direct-minimal-versions" test #555

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Update MSRV and replace "minimal-versions" check with "direct-minimal-versions" test #555

merged 2 commits into from
Mar 11, 2024

Conversation

cospectrum
Copy link
Contributor

@cospectrum cospectrum commented Mar 11, 2024

-Zminimal-versions + cargo check will validate only default features without dev-dependencies.
But -Zminimal-versions + cargo +nightly test --all-targets --all-features is completely broken due to indirect dependencies.
We can try to update with -Zdirect-minimal-versions instead and then test.

MSRV updated from 1.63 to 1.65 for property-testing feature. Added --all-features to the msrv workflow (note: additional --all-targets flag will not work due to nightly tests).

@cospectrum
Copy link
Contributor Author

cospectrum commented Mar 11, 2024

I'm actually not sure if we should increase MSRV to 1.65. But this way we will support one MSRV for all-features

@CommanderStorm
Copy link

not sure if we should update MSRV to 1.65

Given that image-rs has a MSRV of 1.67.1 and that they are likely used together I don't think this should be a roadblock, or is there something I am missing/misunderstanding?

@cospectrum
Copy link
Contributor Author

not sure if we should update MSRV to 1.65

Given that image-rs has a MSRV of 1.67.1 and that they are likely used together I don't think this should be a roadblock, or is there something I am missing/misunderstanding?

True, updating to the new image = "0.25" requires 1.67.1 rustc. We are currently dependent on "0.24.7", but it's probably a good idea to keep up

@fintelia
Copy link

fintelia commented Mar 11, 2024

For what it's worth, the release of image 0.25 and the associated MSRV bump happened literally yesterday 😄

@theotherphil theotherphil merged commit 3d3ed0c into image-rs:master Mar 11, 2024
14 checks passed
@cospectrum cospectrum deleted the direct-minimal-lock branch March 11, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants