Switch from rulinalg to nalgebra for SVD #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Palladinium
changed the title
Palladinium
changed the title
arcdarcd
added a commit
to arcdarcd/noaa-apt
that referenced
this pull request
Aug 25, 2020
After running `cargo audit`, it turns out `imageproc` crate has a known vulnerability: https://rustsec.org/advisories/RUSTSEC-2020-0023 Also, we're no longer using anything from this crate. If we need something in the future, keep an eye on this pull request that seems to solve the issue by swapping the vulnerable dependency in imageproc with another crate: image-rs/imageproc#417 Details: ``` $cargo audit error: Vulnerable crates found! ID: RUSTSEC-2020-0023 Crate: rulinalg Version: 0.4.2 Date: 2020-02-11 URL: https://rustsec.org/advisories/RUSTSEC-2020-0023 Title: Lifetime boundary for `raw_slice` and `raw_slice_mut` are incorrect Solution: No safe upgrade is available! Dependency tree: rulinalg 0.4.2 └── imageproc 0.21.0 └── noaa-apt 1.2.0 ```
martinber
pushed a commit
to martinber/noaa-apt
that referenced
this pull request
Sep 17, 2020
After running `cargo audit`, it turns out `imageproc` crate has a known vulnerability: https://rustsec.org/advisories/RUSTSEC-2020-0023 Also, we're no longer using anything from this crate. If we need something in the future, keep an eye on this pull request that seems to solve the issue by swapping the vulnerable dependency in imageproc with another crate: image-rs/imageproc#417 Details: ``` $cargo audit error: Vulnerable crates found! ID: RUSTSEC-2020-0023 Crate: rulinalg Version: 0.4.2 Date: 2020-02-11 URL: https://rustsec.org/advisories/RUSTSEC-2020-0023 Title: Lifetime boundary for `raw_slice` and `raw_slice_mut` are incorrect Solution: No safe upgrade is available! Dependency tree: rulinalg 0.4.2 └── imageproc 0.21.0 └── noaa-apt 1.2.0 ```
|
I've been spending some time testing and debugging this branch, as well as reading into the linear algebra behind the logic here, and I'm now pretty reasonably confident I'm doing this right. It should be safe to merge, but once again it'd be good if someone with a better background in mathematics could double-check this. |
|
Today I ran |
|
I've tried out this PR, and it works more reliably the the code it replaces. |
|
Thanks! Sorry about the very long delay. |
|
Thank you guys for the very quick test and merge! When can we expect a release including this merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
This is working fine on a private project, but I don't know much about linear algebra and there aren't nearly enough test cases to ensure this doesn't break a bunch of stuff, so someone who's more knowledgeable should double check this.