Skip to content

Code Review

IlyaMarkovMipt edited this page Dec 13, 2016 · 2 revisions

This is some kind of code review of project Capo_multifiles

To all files

It would be easier to understand what's happening there, if there were more comments.:)

Lines 186, 193:

May be don't print it every time, but collect somewhere and print if needed?

Lines 72,93, 113, 139, 145:

Some functions can be private due to logic or, may be, put them ins, as far as I understand.

May be save only train() and detect(), others are out of interface? It would increase readibility.

Line 39

The same. This function could be private.

Nothing more can add.

Clone this wiki locally