fixes serialization issue with enrollment class. #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running Moodle-core test coverage with this enrollment plugin integrated causes several failures, all with a
Exception: Serialization of 'Closure' is not allowed
.Here is one example:
Using a step-through debugger, I was able to pinpoint the problem - the Ilios API client cannot be set as class member during serialization, since brings in closures of the underlying HTTP client (Guzzle).
See screenshot below with highlighted closures:
I'm side-stepping this issue by getting the client inside the only function that's actually using it. that get's around this problem since the methods in an object will not be saved, only the name of the class.
after the change/for comparison: