Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaces test-breaking assertions in closures with history-middleware… #63

Merged
merged 1 commit into from
Oct 24, 2024
Merged

replaces test-breaking assertions in closures with history-middleware… #63

merged 1 commit into from
Oct 24, 2024

Conversation

stopfstedt
Copy link
Member

… powered equivalent.

companion PR to ilios/tool_ilioscategoryassignment#28

@stopfstedt stopfstedt marked this pull request as ready for review October 24, 2024 00:01
@stopfstedt stopfstedt requested a review from jrjohnson October 24, 2024 00:01
jrjohnson
jrjohnson approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@jrjohnson jrjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I did my best to audit that the same assertions were in the new spot, but I got a bit dizzy. LGTM.

@jrjohnson jrjohnson merged commit 59c1cba into ilios:MOODLE_404_STABLE Oct 24, 2024
4 checks passed
@stopfstedt stopfstedt mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrjohnson jrjohnson jrjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stopfstedt @jrjohnson