Skip to content

Commit

Permalink
Remove direct _llseek code and require long filesystem libc.
Browse files Browse the repository at this point in the history
  • Loading branch information
doughdemon authored and phcoder committed Jan 22, 2015
1 parent 6866f2b commit 3bac4ca
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 24 deletions.
4 changes: 4 additions & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
2015-01-22 Felix Janda <[email protected]>

Remove direct _llseek code and require long filesystem libc.

2015-01-20 Vladimir Serbinenko <[email protected]>

Remove potential division by 0 in gfxmenu.
Expand Down
1 change: 1 addition & 0 deletions INSTALL
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ configuring the GRUB.
* GNU binutils 2.9.1.0.23 or later
* Flex 2.5.35 or later
* Other standard GNU/Unix tools
* a libc with large file support (e.g. glibc 2.1 or later)

On GNU/Linux, you also need:

Expand Down
8 changes: 8 additions & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,14 @@ case "$host_os" in
;;
esac

case "$host_os" in
cygwin | windows* | mingw32* | aros*)
;;
*)
AC_CHECK_SIZEOF(off_t)
test x"$ac_cv_sizeof_off_t" = x8 || AC_MSG_ERROR([Large file support is required]);;
esac

if test x$USE_NLS = xno; then
HOST_CFLAGS="$HOST_CFLAGS -fno-builtin-gettext"
fi
Expand Down
24 changes: 0 additions & 24 deletions grub-core/osdep/unix/hostdisk.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@
#ifdef __linux__
# include <sys/ioctl.h> /* ioctl */
# include <sys/mount.h>
# if !defined(__GLIBC__) || \
((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1)))
/* Maybe libc doesn't have large file support. */
# include <linux/unistd.h> /* _llseek */
# endif /* (GLIBC < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR < 1)) */
#endif /* __linux__ */

grub_uint64_t
Expand All @@ -79,24 +74,6 @@ grub_util_get_fd_size (grub_util_fd_t fd, const char *name, unsigned *log_secsiz
return st.st_size;
}

#if defined(__linux__) && (!defined(__GLIBC__) || \
((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1))))
/* Maybe libc doesn't have large file support. */
int
grub_util_fd_seek (grub_util_fd_t fd, grub_uint64_t off)
{
loff_t offset, result;
static int _llseek (uint filedes, ulong hi, ulong lo,
loff_t *res, uint wh);
_syscall5 (int, _llseek, uint, filedes, ulong, hi, ulong, lo,
loff_t *, res, uint, wh);

offset = (loff_t) off;
if (_llseek (fd, offset >> 32, offset & 0xffffffff, &result, SEEK_SET))
return -1;
return GRUB_ERR_NONE;
}
#else
int
grub_util_fd_seek (grub_util_fd_t fd, grub_uint64_t off)
{
Expand All @@ -107,7 +84,6 @@ grub_util_fd_seek (grub_util_fd_t fd, grub_uint64_t off)

return 0;
}
#endif


/* Read LEN bytes from FD in BUF. Return less than or equal to zero if an
Expand Down

0 comments on commit 3bac4ca

Please sign in to comment.