Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IN REVIEW] Add basic functionality for dynamic analysis #339
base: main
Are you sure you want to change the base?
[IN REVIEW] Add basic functionality for dynamic analysis #339
Changes from all commits
e9a04c4
bd4b330
7a24573
f380a92
c1468bf
ca677a2
53ccfea
042994f
7c4ee31
d7dc1a2
f8d8358
cea9327
44647b7
b69dafc
1f23adb
39eead8
8558db1
d9be16f
232c09c
7c39a00
1649073
4e546d3
9f92ea6
da2c875
75290a9
c217585
1a23f77
89d511c
7093fdc
8dc4470
cf601ae
731b506
67fbd27
ef82f44
6cc0063
b0421b0
f6fbfb9
307a584
e2e27b9
94d8fa3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 178 in ikarus/assembler/assemblermanipulatorbuildingblocks.hh
Codecov / codecov/patch
ikarus/assembler/assemblermanipulatorbuildingblocks.hh#L178
Check warning on line 182 in ikarus/assembler/assemblermanipulatorbuildingblocks.hh
Codecov / codecov/patch
ikarus/assembler/assemblermanipulatorbuildingblocks.hh#L182
Check warning on line 202 in ikarus/assembler/assemblermanipulatorbuildingblocks.hh
Codecov / codecov/patch
ikarus/assembler/assemblermanipulatorbuildingblocks.hh#L202
Check warning on line 206 in ikarus/assembler/assemblermanipulatorbuildingblocks.hh
Codecov / codecov/patch
ikarus/assembler/assemblermanipulatorbuildingblocks.hh#L206
Check warning on line 124 in ikarus/assembler/simpleassemblers.inl
Codecov / codecov/patch
ikarus/assembler/simpleassemblers.inl#L124
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall our discussion correctly, we said that here instead of the
bool
, perhaps we can pass the pruning functor instead of it happening in the lumping function here. Did you face any problems with this? I am not sure but perhaps passing a functor and defaulting it to existing functions can avoid theif constexpr
here? May be the pruning functor can also be something that the user can bind to the assembler and overwrite a default?Check warning on line 156 in ikarus/assembler/simpleassemblers.inl
Codecov / codecov/patch
ikarus/assembler/simpleassemblers.inl#L156
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be enough that
KirchhoffLoveShellPre
has the default isn't it? Here it can be removed? Similar for all the skillsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then KlArgs are not constructable without providing a density anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I ll remove it from the Skill itself, as noone is constructing it withouth the helper function