-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1448 kolumny rownej szerokosci #1761
Open
olanicp
wants to merge
6
commits into
master-dev
Choose a base branch
from
1448-kolumny-rownej-szerokosci
base: master-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
36fe25e
Zmieniona szerokosc pierwszej kolumny na najmniejsza
olanicp 123ec64
Dodaj zawijanie tekstu na malych ekranach
olanicp 3b9e980
fix lint issues
olanicp f5cebe4
zmiana breakpointa na stałą, dodanie stylowania dla odpowiedniej klasy
olanicp 10d66ff
refaktoryzacja
olanicp a8f5f55
change id to class
olanicp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
zapisy/apps/offer/proposal/templates/proposal/proposal_info.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potrzebujemy dodawać te nowe klasy? Czy nie wystarczą selektory
#table-info .table-info-type
w pierwszym przypadku i#table-offer th
w drugim?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dodałam te klasy bo po sprawdzeniu #table-info i .table-info-type występują też w pliku thesis.html więc wydawało mi się że stylowanie w ten sposób wpłynęłoby na ten widok. Jeszcze raz to zweryfikuje w takim razie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, cenna uwaga. Proszę w takim razie przyjrzeć się wszystkim miejscom, gdzie występuje selektor
colgroup col.table-info-type
i popatrzyć (to są dwie różne rzeczy):master-dev
;background-color
coś zmienia (tj. międzymaster-dev
a tym branczem).Zgaduję, że w 1. okaże się, że kolorowanie wszędzie znikło, a 2. już nie ma znaczenia (co będzie oznaczać, że usunięcie tej deklaracji było tym bardziej właściwe). Jeśli się to potwierdzi, to proszę założyć nowy issue o przywróceniu kolorowania tła w tych miejscach. Później zdecydujemy też, jak rozwiązać "kolizję selektorów", która pojawiła się tutaj.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Faktycznie, sprawdziłam punkt 1. kolorowanie wszędzie zniknęło (gdy wybierzemy pracownika z listy pracowników, to samo ze studentami, gdy klikniemy w jakąś pracę dyplomową i gdy wejdziemy w Moje konto - czyli we wszystkich plikach które korzystają z table-info-type). Drugiego punktu już nie sprawdzałam.