Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mail issue #151

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Mail issue #151

merged 1 commit into from
Mar 18, 2023

Conversation

deepakgohil9
Copy link
Member

@deepakgohil9 deepakgohil9 commented Mar 18, 2023 •
edited
Loading

Fixes #152

Description

As sendgrid mails are getting blocked due to DMARC policy therefore gmail smtp is used to send mails.

Screenshot Before Change:

Screenshot After Change:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Non Functional Requirement

  • Follows the code style of this project.
  • Tests Cover Changes
  • I have performed a self-review of my own code
  • All new and existing tests passed.
  • Documentation

@Im-Madhur-Gupta Im-Madhur-Gupta changed the base branch from master to deploy March 18, 2023 16:47
@Im-Madhur-Gupta Im-Madhur-Gupta self-requested a review March 18, 2023 16:48
Im-Madhur-Gupta
Im-Madhur-Gupta approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@Im-Madhur-Gupta Im-Madhur-Gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Im-Madhur-Gupta Im-Madhur-Gupta merged commit 693096b into deploy Mar 18, 2023
@Im-Madhur-Gupta Im-Madhur-Gupta deleted the mail-issue branch March 18, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Im-Madhur-Gupta Im-Madhur-Gupta Im-Madhur-Gupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sendemail endpoint
2 participants
@deepakgohil9 @Im-Madhur-Gupta