-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dac tutorial add tech #810
base: main
Are you sure you want to change the base?
Conversation
…_removal, NOTE: this is broken because the YAML file needs to be updated based on removing old daccs-specific code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #810 +/- ##
=======================================
- Coverage 95.4% 91.8% -3.6%
=======================================
Files 46 47 +1
Lines 4354 4524 +170
=======================================
Hits 4156 4156
- Misses 198 368 +170
|
Hi @gidden, please clarify for me: I thought we wanted to have the tutorials be part of message-ix-models. Was this decision revised? Should I still set up a docs page etc for tutorials in message-ix-models? |
Hey @glatterf42 - good questions. Yes, in reviewing this PR and related work with @ywpratama yesterday, we realized that his So in short, no need to add tutorials page yet to message-ix-models |
@glatterf42 and @ywpratama - this PR now has the content added to it that is expected. It would be useful if the two of you could sit down and discuss how to best add relevant tests for this so it can be merged. @ywpratama there should be already available documentation for how to pass the code quality checks |
This is a fresh PR where we will implement DACCS related tutorials. It depends on iiasa/message-ix-models#158 where additional features for implementing DACCS in scenarios are developed.
This supercedes #793 and #806
FYI @ywpratama
Required: write a single sentence that describes the changes made by this PR.
How to review
Required: describe specific things that reviewer(s) must do, in order to ensure that the PR achieves its goal.
If no review is required, write “No review:” and describe why.
PR checklist