fix: fix the incorrect handling of the sample parameter in `sample_…

…motifs()` and ensure that the default `sample.size` is integer
igraph · Oct 31, 2024 · b84732e · b84732e
1 parent a871789
commit b84732e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/R/motifs.R b/R/motifs.R
@@ -216,7 +216,7 @@ count_motifs <- function(graph, size = 3, cut.prob = rep(0, size)) {
 #' count_motifs(g, 3)
 #' sample_motifs(g, 3)
 sample_motifs <- function(graph, size = 3, cut.prob = rep(0, size),
-                          sample.size = vcount(graph) / 10, sample = NULL) {
+                          sample.size = ceiling(vcount(graph) / 10), sample = NULL) {
   ensure_igraph(graph)
   cut.prob <- as.numeric(cut.prob)
   if (length(cut.prob) != size) {
@@ -226,6 +226,10 @@ sample_motifs <- function(graph, size = 3, cut.prob = rep(0, size),
     )
   }
 
+  if (!is.null(sample)) {
+    sample <- as_igraph_vs(graph, sample) - 1
+  }
+
   on.exit(.Call(R_igraph_finalizer))
   .Call(
     R_igraph_motifs_randesu_estimate, graph, as.numeric(size),

diff --git a/man/sample_motifs.Rd b/man/sample_motifs.Rd