Skip to content

Commit

Permalink
CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
krlmlr committed Oct 18, 2024
1 parent d259156 commit 2839800
Showing 1 changed file with 37 additions and 6 deletions.
43 changes: 37 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
igraph 2.1.0
igraph 2.1.1

## R CMD check results

Expand All @@ -8,17 +8,48 @@ igraph 2.1.0

## Current CRAN check results

- [x] Checked on 2024-09-26, problems found: https://cran.r-project.org/web/checks/check_results_igraph.html
- [x] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc
- [x] Checked on 2024-10-18, problems found: https://cran.r-project.org/web/checks/check_results_igraph.html
- [ ] NOTE: r-devel-linux-x86_64-debian-clang, r-devel-linux-x86_64-debian-gcc, r-devel-linux-x86_64-fedora-clang, r-devel-linux-x86_64-fedora-gcc
File ‘igraph/libs/igraph.so’:
Found non-API calls to R: ‘PRENV’, ‘R_PromiseExpr’

Fixed.
- [x] WARN: r-devel-linux-x86_64-fedora-gcc
Compiled code should not call non-API entry points in R.

See ‘Writing portable packages’ in the ‘Writing R Extensions’ manual,
and section ‘Moving into C API compliance’ for issues with the use of
non-API entry points.
- [ ] WARN: r-devel-linux-x86_64-debian-gcc
Found the following significant warnings:
Warning: Obsolescent feature: Old-style character length at (1)
See ‘/home/hornik/tmp/R.check/r-devel-gcc/Work/PKGS/igraph.Rcheck/00install.out’ for details.
* used C compiler: ‘gcc-14 (Debian 14.2.0-6) 14.2.0’
* used C++ compiler: ‘g++-14 (Debian 14.2.0-6) 14.2.0’
- [ ] WARN: r-devel-linux-x86_64-fedora-gcc
Found the following significant warnings:
Warning: Obsolescent feature: Old-style character length at (1)
See ‘/data/gannet/ripley/R/packages/tests-devel/igraph.Rcheck/00install.out’ for details.
* used C compiler: ‘gcc-14 (GCC) 14.2.0’
* used C++ compiler: ‘g++-14 (GCC) 14.2.0’
- [ ] WARN: r-devel-windows-x86_64
Found the following significant warnings:
Warning: Obsolescent feature: Old-style character length at (1)
See 'd:/Rcompile/CRANpkg/local/4.5/igraph.Rcheck/00install.out' for details.
* used C compiler: 'gcc.exe (GCC) 13.2.0'
* used C++ compiler: 'g++.exe (GCC) 13.2.0'
- [ ] NOTE: r-devel-windows-x86_64
File 'igraph/libs/x64/igraph.dll':
Found non-API calls to R: 'PRENV', 'R_PromiseExpr'

Compiled code should not call non-API entry points in R.

Need fix upstream.
See 'Writing portable packages' in the 'Writing R Extensions' manual,
and section 'Moving into C API compliance' for issues with the use of
non-API entry points.
- [ ] other_issue: NA
See: <https://www.stats.ox.ac.uk/pub/bdr/gcc/igraph.out>
- [ ] other_issue: NA
See: <https://www.stats.ox.ac.uk/pub/bdr/noSuggests/igraph.out>
- [ ] other_issue: NA
See: <https://raw.githubusercontent.com/kalibera/cran-checks/master/rchk/results/igraph.out>

Check results at: https://cran.r-project.org/web/checks/check_results_igraph.html

0 comments on commit 2839800

Please sign in to comment.