Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache when creating or updating MUCs #111

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

Fishbowler
Copy link
Member

When clustering, the MUC goes into the cache, but doesn't get an ID, and the savedToDB value is incorrect. No idea if this has any real world impact, but it's certainly wrong. This forces a sync the same way that Admin does when it creates a room.

Could this be #30?

@guusdk
Copy link
Member

guusdk commented Jun 24, 2022

I'm not yet sure if I understand your underlying issue, but synchronizing the implementation to what Openfire itself is doing, makes sense. Ideally, we introduce some easy-to-use API in Openfire that can be used for this purpose, instead of copy/pasting boilerplate code.

@Fishbowler
Copy link
Member Author

Have added to #30 (comment):

When I'm in a cluster and I create a room, the room exists properly in the database, but is incorrect in the cache. When I look at it in the cache, the settings are wrong, the ID is -1, and the savedToDB value is False.

I've not played with the effects of this, but suspect that if the cache is incorrect, it'd lead to all sorts of problems until the server is next restarted or the cache is otherwise repopulated.

When clustering, the MUC goes into the cache, but doesn't get an ID, and the savedToDB value is incorrect. No idea if this has any real world impact, but it's certainly wrong. This forces a sync the same way that Admin does when it creates a room.
@guusdk guusdk merged commit ef42403 into igniterealtime:main Jun 24, 2022
@Fishbowler Fishbowler deleted the fix_caching branch June 27, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants