Prefer to log to a file, not std-err

igniterealtime · Sep 19, 2024 · f3af3f4 · f3af3f4
1 parent 748d0b5
commit f3af3f4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/org/jivesoftware/site/PluginDownloadServlet.java b/src/main/java/org/jivesoftware/site/PluginDownloadServlet.java
@@ -480,7 +480,7 @@ public static List<PluginManager.Metadata> getPlugins( File pluginDir ) throws I
                 }
                 catch ( IOException | DocumentException e )
                 {
-                    e.printStackTrace();
+                    Log.warn("Unable to load metadata from '{}'", mavenFile, e);
                 }
                 return null;
             } )

diff --git a/src/main/java/org/jivesoftware/site/PluginManager.java b/src/main/java/org/jivesoftware/site/PluginManager.java
@@ -177,7 +177,7 @@ private static Set<Metadata> getPlugins( Path path ) throws IOException
                     }
                     catch ( IOException | DocumentException e )
                     {
-                        e.printStackTrace();
+                        Log.warn("Unable to read metadata from '{}'", mavenFile, e);
                     }
                     return null;
                 } )

diff --git a/src/main/webapp/projects/openfire/plugin-archive.jsp b/src/main/webapp/projects/openfire/plugin-archive.jsp
@@ -20,6 +20,7 @@
 <%@ page import="java.util.jar.JarFile" %>
 <%@ page import="org.jsoup.Jsoup" %>
 <%@ page import="org.jsoup.safety.Safelist" %>
+<%@ page import="org.slf4j.LoggerFactory" %>
 <%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>
 <%@ taglib uri="http://igniterealtime.org/website/tags" prefix="ir" %>
 <%
@@ -56,7 +57,7 @@
                 request.setAttribute("cleanHtml", cleanHtml);
             } catch (Exception e) {
                 // This should not prevent the rest of the page from displaying.
-                e.printStackTrace();
+                LoggerFactory.getLogger("plugin-archive.jsp").warn("Unexpected exception while processing readme of {}", latestPluginMetadata.mavenFile, e);
             }
         }
     }