Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci tests #25

Merged
merged 10 commits into from
Jun 8, 2020
Merged

Feature/ci tests #25

merged 10 commits into from
Jun 8, 2020

Conversation

rodrigondec
Copy link
Member

@rodrigondec rodrigondec commented Jun 3, 2020

Descrição das Mudanças

Adiciona no ci:

  • testes do 'npm'
  • lintagem do 'npm'
  • coverage

Relacionado a issue #24

Mudanças na API

N/A

Mudanças de comportamento

N/A

Testing Procedure

Rodando o CI nesse PR

PR Checklist

  • Possui testes (se não, por favor descreva o motivo de não ter teste)
  • Foi feito Rebase para a master no momento que o PR foi aberto
  • Modificações estão de acordo com o padrão de código
  • Atualizado documentação

PR Checklist do time

  • O PR está apontando para a branch correta
  • Os testes estão passando (ou as falha não são relacionadas a este PR)

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@cba80a1). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             dev       #25   +/-   ##
=======================================
  Coverage       ?   100.00%           
=======================================
  Files          ?        11           
  Lines          ?        73           
  Branches       ?         5           
=======================================
  Hits           ?        73           
  Misses         ?         0           
  Partials       ?         0           

@rodrigondec rodrigondec requested review from pabrrs, tgspn, deniojunior, pictos and mastercoks and removed request for pabrrs June 3, 2020 01:59
Copy link
Member

@pabrrs pabrrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bom @rodrigondec 🎉

Como o branch dev não possui nenhum relatório de coverage para comparar, acho que vale desativar apenas nessa PR o required para o step codecov/project.

Makefile Outdated Show resolved Hide resolved
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@deniojunior deniojunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodrigondec Excelente!

Os pontos que o @pabrrs levantou são válidos. Além deles, sugeri somente adicionar uma quebra de linha no final dos arquivos, nada demais

.github/workflows/coverage.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@rodrigondec rodrigondec requested review from pabrrs and deniojunior June 5, 2020 23:19
@pictos
Copy link
Contributor

pictos commented Jun 5, 2020

@rodrigondec , essa falha não é relacionada a esse PR?

@rodrigondec
Copy link
Member Author

@rodrigondec , essa falha não é relacionada a esse PR?

Não. É pq o codecov compara a cobertura do PR atual com a cobertura da branch de destino.

Que no caso não existe uma cobertura anterior para a dev. Então ele falha.

Copy link
Member

@pabrrs pabrrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@deniojunior deniojunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boa!

@rodrigondec rodrigondec merged commit 9b5642a into dev Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants