-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ci tests #25
Feature/ci tests #25
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #25 +/- ##
=======================================
Coverage ? 100.00%
=======================================
Files ? 11
Lines ? 73
Branches ? 5
=======================================
Hits ? 73
Misses ? 0
Partials ? 0 |
8680b71
to
c84ba8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muito bom @rodrigondec 🎉
Como o branch dev
não possui nenhum relatório de coverage para comparar, acho que vale desativar apenas nessa PR o required para o step codecov/project
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rodrigondec Excelente!
Os pontos que o @pabrrs levantou são válidos. Além deles, sugeri somente adicionar uma quebra de linha no final dos arquivos, nada demais
@rodrigondec , essa falha não é relacionada a esse PR? |
Não. É pq o codecov compara a cobertura do PR atual com a cobertura da branch de destino. Que no caso não existe uma cobertura anterior para a dev. Então ele falha. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boa!
Descrição das Mudanças
Adiciona no ci:
Relacionado a issue #24
Mudanças na API
N/A
Mudanças de comportamento
N/A
Testing Procedure
Rodando o CI nesse PR
PR Checklist
PR Checklist do time