Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several upgrades! :-) #56

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Several upgrades! :-) #56

wants to merge 30 commits into from

Conversation

lspohn
Copy link

@lspohn lspohn commented Sep 3, 2018

Hey!

I really like your work and am going to adapt it to our special needs. I try to contribute all changes that might be useful for public.

New Features:

  • All dependencies upgraded to latest version
  • Webpack upgraded to v4
  • HTML, CSS and media has been moved to /static
  • Localization added - detecting browser language and changing all strings dynamically (English as default)
  • Localization strings can be modified by user or default configuration can be used
  • German localization included, other languages can easily be added (just use https://deepl.com/translator ...)
  • Time-of-Day-dependant activation of the widget, 1-2 time windows configurable, e.g 9-11am and 1-4pm (UTC as reference)
  • Users get random name using faker.js (user names are now retrieved from the server via GET) instead of randoms strings (-> makes it easier to remember and distinguish multiple users)
  • Message input box with 4 rows -> should be enough for most messages
  • Some design changes (rounded corners, different font, smaller paddings, different coloring of visitor/admin, consequently using "rem" units)

What could still be done in terms of build infrastructure (nice-to-have but not neccesary)

  • Enabling webpack-dev-server with hot module replacement. Currently, it doesn't work because webpeck doesn't inject it's configuration into the html files. You have to rerun "npm run dev/build/css" after each change and refresh in browser manually, disabling caching.

Project runs fine for me but please test it before accepting the request. ;-)

Regards & thanks,
Lucas

@lspohn
Copy link
Author

lspohn commented Sep 3, 2018

First want to do some more tests tomorrow, then I'll reopen the pull request!

@lspohn lspohn closed this Sep 3, 2018
@idoco
Copy link
Owner

idoco commented Sep 3, 2018

Wow, this looks very interesting. Let me know when it’s ready and I will start reviewing it.

@lspohn lspohn reopened this Sep 3, 2018
@luisalvarado
Copy link

At the end, was this integrated @idoco I think this was already based on how it works, although if multiple visitors check the website and chat, all of them will see the chat of everyone else for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants