-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bootstrap5 templates #304
Conversation
Thank you. This class thing could be useful indeed, so I'd like to ask you also to update the docs: to mention this extra class and new templates. https://github.com/idlesign/django-sitetree/blob/master/docs/source/templatesmod.rst And another thing: it'd probably more flexible if we call that |
docs/source/templatesmod.rst
Outdated
@@ -14,6 +14,12 @@ Nevertheless pay attention that menu template also uses two CSS classes marking | |||
* **current_item** — marks item in the tree, corresponding to current page; | |||
* **current_branch** — marks all ancestors of current item, and current item itself. | |||
|
|||
If needed, you can set estra CSS classes to the *ul* element with `extra_class_ul` variable. For example:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here — extra.
Also missing the new templates listing.
@idlesign I have changed the PR to your suggestions. BTW There is 1 more thing, for which I have to override the whole template. I am using font-awesome icons, so I need to make the {% block title %}{{ item.title_resolved }}{% endblock %} so that only this part of the template needs to be overriden, or it can be done by some settings (like |
Thank you. There's the pending issue though — #304 (comment)
This has no connection to Bootstrap template. Let's open another issue to discuss it, if it's required. Yet, I'd rather try to play with |
Thank you. Merged. |
I have added templates for Bootstrap 5. The only difference, that is really needed is renaming of
data-toggle
todata-bs-toggle
.But I also added the
{{ extra_class}}
attribute which I found very handy. It can be used this way: