Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support identifying authenticators with strings #33

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Oct 17, 2024

enables declarative config without needing Python config files, which will be important to make this convenient in a helm chart config

@minrk minrk changed the title support identifying authenticators with strings feat: support identifying authenticators with strings Oct 17, 2024
Copy link
Member

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !

Thank you

Can you rebase on the current main branch please ?

@minrk minrk force-pushed the importable-strings branch from fea5ea8 to c4e4479 Compare October 18, 2024 08:41
enables fully declarative config (e.g. yaml in helm chart)

requires importlib_metadata backport for entrypoints on Python < 3.10
@minrk minrk force-pushed the importable-strings branch from c4e4479 to 3bd1885 Compare October 18, 2024 08:43
Python 3.9 has it, but is missing entrypoint groups
Copy link
Member

@sgaist sgaist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgaist sgaist merged commit a999a2d into idiap:main Oct 18, 2024
16 checks passed
@minrk minrk deleted the importable-strings branch October 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants