Logging: handle verbosity as a ResourceOption
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `verbosity_option` is a `ResourceOption` (to make the verbosity settable by a config), the logging level will not be set for the logs in the config files.
Coverage report
This PR does not seem to contain any modification to coverable code. |
Ensure the log level is set in config files when `verbosity_option` is not a `ResourceOption`. Ensure the log level is still correctly imported from the config when `verbosity_option` is a `ResourceOption`.
Yannick-Dayer
force-pushed
the
fix/verbosity-as-config
branch
from
97453aa to
a6093ce
Compare
Add information on the behavior of the `verbosity_option` when it is set as `ResourceOption`. Fix a typos in an help message (propagating the change in the tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
verbosity_optionis aResourceOption(to make the verbosity settable by a config), the logging level will not be set for the logs in the config files (the level of the rest of the app is fine).Otherwise, when
verbosity_optionis a "simple" option, the verbosity will be set correctly during the loading of the config files.Fixes #11.
📚 Documentation preview 📚: https://clapper--12.org.readthedocs.build/en/12/