fix: handle servers not answering to HEAD requests #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
|
I noticed the issue with The HEAD request for the file https://www.idiap.ch/software/bob/docs/bob/bob.pipelines/master/sphinx/objects.inv` works. |
`requests.head` fails on some links due to an encoding issue. This forces the accepted encoding to be simple to accomodate most servers.
Yannick-Dayer
force-pushed
the
fix/head-fallback
branch
from
158455a to
c183323
Compare
|
This new version directly fixes the problem instead of circumventing it with a try-except. Thanks to @PuckCh for finding out what the underlying problem was: the default supported encoding set by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some servers will close the connection with
requests.headon some pages.Set the
requests.headaccepted encoding to support those failing links.📚 Documentation preview 📚: https://auto-intersphinx--2.org.readthedocs.build/en/2/