Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black screen bug by make CameraManager a singleton #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiaminglu
Copy link

Also removed a error log "Method called after release()" caused by calling stopCameraPreview twice

Fix "Method called after release()" caused by calling stopCameraPreview twice
@jiaminglu jiaminglu changed the title Fix black screen bug by make CameraPreview a singleton Fix black screen bug by make CameraManager a singleton Oct 25, 2016
@vysakh0
Copy link

vysakh0 commented Nov 11, 2016

@ideacreation If this PR is merged, it would be useful.

@jiaminglu Thank you for the PR, wondering how to use this into my project in case the PR is not yet merged. Should I copy the CameraManager.java file into android/app/src/main/java/com/myAppName/ ?

@Scimonster
Copy link

@vysakh0 I just added "react-native-barcodescanner": "jiaminglu/react-native-barcodescanner" to my package.json to use his fork.

@vysakh0
Copy link

vysakh0 commented Nov 22, 2016

@Scimonster Thank you! Initially I used yarn, for some reason it didn't pull jiaminglu's code. So did a npm install and it worked.

@knapeto
Copy link

knapeto commented Nov 23, 2016

Can we marge it ?

@HonzaMac
Copy link

Are there any blockers, which prevent @andreaskeller from merging this PR and release this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants